<html>
<head><meta charset="utf-8"><title>github access for wg · t-compiler/wg-rustc-dev-guide · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/index.html">t-compiler/wg-rustc-dev-guide</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/topic/github.20access.20for.20wg.html">github access for wg</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="175532071"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/196385-t-compiler/wg-rustc-dev-guide/topic/github%20access%20for%20wg/near/175532071" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/topic/github.20access.20for.20wg.html#175532071">(Sep 12 2019 at 14:04)</a>:</h4>
<p>hey <span class="user-mention" data-user-id="116009">@nikomatsakis</span>, <span class="user-mention" data-user-id="121055">@Pietro Albini</span> raised a discussion about what level of access do we want to give to people belonging to this wg</p>



<a name="175532108"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/196385-t-compiler/wg-rustc-dev-guide/topic/github%20access%20for%20wg/near/175532108" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/topic/github.20access.20for.20wg.html#175532108">(Sep 12 2019 at 14:04)</a>:</h4>
<p>and I guess that is a general discussion that may apply to all wgs</p>



<a name="175532165"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/196385-t-compiler/wg-rustc-dev-guide/topic/github%20access%20for%20wg/near/175532165" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/topic/github.20access.20for.20wg.html#175532165">(Sep 12 2019 at 14:05)</a>:</h4>
<p><span class="user-mention" data-user-id="121055">@Pietro Albini</span> can you describe the different levels and what each level is allowed to do?</p>



<a name="175532190"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/196385-t-compiler/wg-rustc-dev-guide/topic/github%20access%20for%20wg/near/175532190" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/topic/github.20access.20for.20wg.html#175532190">(Sep 12 2019 at 14:05)</a>:</h4>
<p><a href="https://help.github.com/en/articles/repository-permission-levels-for-an-organization" target="_blank" title="https://help.github.com/en/articles/repository-permission-levels-for-an-organization">https://help.github.com/en/articles/repository-permission-levels-for-an-organization</a></p>



<a name="175532477"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/196385-t-compiler/wg-rustc-dev-guide/topic/github%20access%20for%20wg/near/175532477" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/topic/github.20access.20for.20wg.html#175532477">(Sep 12 2019 at 14:08)</a>:</h4>
<p>for rustc-guide, tbh giving write access with branch protection enabled for master shouldn't be an issue</p>



<a name="175532508"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/196385-t-compiler/wg-rustc-dev-guide/topic/github%20access%20for%20wg/near/175532508" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/topic/github.20access.20for.20wg.html#175532508">(Sep 12 2019 at 14:09)</a>:</h4>
<p>you can require an approval from another wg member to be present before they'd be able to merge PRs</p>



<a name="175532929"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/196385-t-compiler/wg-rustc-dev-guide/topic/github%20access%20for%20wg/near/175532929" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/topic/github.20access.20for.20wg.html#175532929">(Sep 12 2019 at 14:14)</a>:</h4>
<p>I guess that could work <span aria-label="+1" class="emoji emoji-1f44d" role="img" title="+1">:+1:</span></p>



<a name="175532982"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/196385-t-compiler/wg-rustc-dev-guide/topic/github%20access%20for%20wg/near/175532982" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/topic/github.20access.20for.20wg.html#175532982">(Sep 12 2019 at 14:14)</a>:</h4>
<p><span class="user-mention" data-user-id="116009">@nikomatsakis</span> ? would that be ok ?</p>



<a name="175641700"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/196385-t-compiler/wg-rustc-dev-guide/topic/github%20access%20for%20wg/near/175641700" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mark-i-m <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/topic/github.20access.20for.20wg.html#175641700">(Sep 13 2019 at 16:44)</a>:</h4>
<p>FWIW, I have had branch protection on for master for a couple months now, requiring a passing travis build before merging. github also supports requiring a approval review from another WG member too</p>



<a name="178277496"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/196385-t-compiler/wg-rustc-dev-guide/topic/github%20access%20for%20wg/near/178277496" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Yuki Okushi <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/topic/github.20access.20for.20wg.html#178277496">(Oct 16 2019 at 10:51)</a>:</h4>
<p>Any updates on this? I think it'd be nice we can merge minor PRs (e.g. updating links, fixing typo, etc.)</p>



<a name="178290510"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/196385-t-compiler/wg-rustc-dev-guide/topic/github%20access%20for%20wg/near/178290510" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/topic/github.20access.20for.20wg.html#178290510">(Oct 16 2019 at 13:50)</a>:</h4>
<p>/cc <span class="user-mention" data-user-id="121055">@Pietro Albini</span> I don't remember exactly</p>



<a name="178290712"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/196385-t-compiler/wg-rustc-dev-guide/topic/github%20access%20for%20wg/near/178290712" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/topic/github.20access.20for.20wg.html#178290712">(Oct 16 2019 at 13:52)</a>:</h4>
<p>write access was not given yet</p>



<a name="178291524"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/196385-t-compiler/wg-rustc-dev-guide/topic/github%20access%20for%20wg/near/178291524" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Yuki Okushi <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/topic/github.20access.20for.20wg.html#178291524">(Oct 16 2019 at 14:00)</a>:</h4>
<p>Is there any plan to give it?</p>



<a name="178291567"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/196385-t-compiler/wg-rustc-dev-guide/topic/github%20access%20for%20wg/near/178291567" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/topic/github.20access.20for.20wg.html#178291567">(Oct 16 2019 at 14:01)</a>:</h4>
<p>dunno, y'all need to decide it</p>



<a name="178291719"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/196385-t-compiler/wg-rustc-dev-guide/topic/github%20access%20for%20wg/near/178291719" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Yuki Okushi <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/topic/github.20access.20for.20wg.html#178291719">(Oct 16 2019 at 14:02)</a>:</h4>
<p>What about? <span class="user-mention" data-user-id="116266">@Santiago Pastorino</span></p>



<a name="178293128"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/196385-t-compiler/wg-rustc-dev-guide/topic/github%20access%20for%20wg/near/178293128" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/topic/github.20access.20for.20wg.html#178293128">(Oct 16 2019 at 14:17)</a>:</h4>
<p><span aria-label="+1" class="emoji emoji-1f44d" role="img" title="+1">:+1:</span> from me /cc <span class="user-mention" data-user-id="198054">@mark-i-m</span></p>



<a name="178321404"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/196385-t-compiler/wg-rustc-dev-guide/topic/github%20access%20for%20wg/near/178321404" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mark-i-m <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/topic/github.20access.20for.20wg.html#178321404">(Oct 16 2019 at 19:36)</a>:</h4>
<p>So the repo is currently set up to require 1 approved review + passing CI</p>



<a name="178321423"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/196385-t-compiler/wg-rustc-dev-guide/topic/github%20access%20for%20wg/near/178321423" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mark-i-m <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/topic/github.20access.20for.20wg.html#178321423">(Oct 16 2019 at 19:37)</a>:</h4>
<p>I think it would be good to give access to merge PRs</p>



<a name="178321436"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/196385-t-compiler/wg-rustc-dev-guide/topic/github%20access%20for%20wg/near/178321436" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mark-i-m <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/topic/github.20access.20for.20wg.html#178321436">(Oct 16 2019 at 19:37)</a>:</h4>
<p>Currently, spastorino and I are acting as bors :P</p>



<a name="178326419"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/196385-t-compiler/wg-rustc-dev-guide/topic/github%20access%20for%20wg/near/178326419" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/topic/github.20access.20for.20wg.html#178326419">(Oct 16 2019 at 20:38)</a>:</h4>
<p><span class="user-mention" data-user-id="121055">@Pietro Albini</span> can you make that happen?</p>



<a name="178326424"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/196385-t-compiler/wg-rustc-dev-guide/topic/github%20access%20for%20wg/near/178326424" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/topic/github.20access.20for.20wg.html#178326424">(Oct 16 2019 at 20:39)</a>:</h4>
<p>or how do we?</p>



<a name="178326446"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/196385-t-compiler/wg-rustc-dev-guide/topic/github%20access%20for%20wg/near/178326446" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/topic/github.20access.20for.20wg.html#178326446">(Oct 16 2019 at 20:39)</a>:</h4>
<p><span class="user-mention" data-user-id="116266">@Santiago Pastorino</span> go to repo settings -&gt; collaborators</p>



<a name="178326454"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/196385-t-compiler/wg-rustc-dev-guide/topic/github%20access%20for%20wg/near/178326454" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/topic/github.20access.20for.20wg.html#178326454">(Oct 16 2019 at 20:39)</a>:</h4>
<p>and switch wg-learning from triage to write</p>



<a name="178326596"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/196385-t-compiler/wg-rustc-dev-guide/topic/github%20access%20for%20wg/near/178326596" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/topic/github.20access.20for.20wg.html#178326596">(Oct 16 2019 at 20:41)</a>:</h4>
<p>done, <span class="user-group-mention" data-user-group-id="1380">@WG-learning</span> the ones on the wg-learning team on github should have write access</p>



<a name="178326613"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/196385-t-compiler/wg-rustc-dev-guide/topic/github%20access%20for%20wg/near/178326613" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/topic/github.20access.20for.20wg.html#178326613">(Oct 16 2019 at 20:41)</a>:</h4>
<p>be aware that there's this <span class="user-group-mention" data-user-group-id="1380">@WG-learning</span> group but there's also the one on github and those not necessarily match</p>



<a name="178326662"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/196385-t-compiler/wg-rustc-dev-guide/topic/github%20access%20for%20wg/near/178326662" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/topic/github.20access.20for.20wg.html#178326662">(Oct 16 2019 at 20:42)</a>:</h4>
<p>ask for permission if you are not in any of those</p>



<a name="178327024"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/196385-t-compiler/wg-rustc-dev-guide/topic/github%20access%20for%20wg/near/178327024" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> amanjeev <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/topic/github.20access.20for.20wg.html#178327024">(Oct 16 2019 at 20:47)</a>:</h4>
<p>hmm how do we know we are in it?</p>



<a name="178327122"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/196385-t-compiler/wg-rustc-dev-guide/topic/github%20access%20for%20wg/near/178327122" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/topic/github.20access.20for.20wg.html#178327122">(Oct 16 2019 at 20:48)</a>:</h4>
<p>here you can check on settings and github you can check on rust-lang/team</p>



<a name="178327177"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/196385-t-compiler/wg-rustc-dev-guide/topic/github%20access%20for%20wg/near/178327177" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> amanjeev <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/topic/github.20access.20for.20wg.html#178327177">(Oct 16 2019 at 20:49)</a>:</h4>
<p><a href="https://github.com/rust-lang/team/blob/master/people/amanjeev.toml" target="_blank" title="https://github.com/rust-lang/team/blob/master/people/amanjeev.toml">https://github.com/rust-lang/team/blob/master/people/amanjeev.toml</a> !! <span aria-label="slight smile" class="emoji emoji-1f642" role="img" title="slight smile">:slight_smile:</span></p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>